Draft
Conversation
This ensures that meson flags defined in src/nix/package.nix are respected in the dev shell.
Also respect the DETSYS_IDS_TELEMETRY environment variable.
Backward compatibility hack for getFlake applied to unsafeDiscardStringContext
This is more consistent with e.g. hash mismatches in fixed-output derivations and the output of `nix path-info`.
LocalStore::addToStore(): Show hash mismatches in SRI format
Upload crash info to Sentry
…vation The hook gets the path of the derivation as an argument, but the derivation typically doesn't exist when called as a remote build.
Scalability bottlenecks currently cause diminishing returns above this. It also prevents creating huge numbers of threads on machines with lots of cores.
boost::thread_resource_error improvements
getLegacyGitAccessor(): Don't ignore errors
Provide the pre-build hook with a JSON serialization of the derivation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Not intended to be merged directly. This PR is a convenience to show the diff between upstream Nix and Determinate Nix (the
mainbranch).Continuation of #4.